Fix/pkg2 #20
Merged
Fix/pkg2 #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd correct package.json BREAKING CHANGE: findAndRequirePackageJson() now requires a callerDir parameter. Previously, the function used __dirname internally which always pointed to the find-and-require-package-json package's own directory, causing it to return the wrong package.json when called from other packages. Now callers must pass their own __dirname (CJS) or dirname(fileURLToPath(import.meta.url)) (ESM) to find the correct package.json. Fixes CI failures in constructive repo where plugins were incorrectly identified as '[email protected]' instead of their actual names. Co-Authored-By: Dan Lynch <[email protected]>
Co-Authored-By: Dan Lynch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.